Apply accessors with greatest visibility first - #220
Draft
kevinthegreat1 wants to merge 1 commit into
Draft
Conversation
Member
You should have multiple mixins with different priorities and have the low priority one have the highest accessor visibility
I'm not sure what tests those are but this PR only sorts accessor methods within each individual mixin which is not enough to solve the issue. |
Member
|
Rather than sorting I think it would be better to have the merging logic take the max visibility of the new and existing methods |
Author
|
Yeah, this is broken, sorry about that. |
kevinthegreat1
marked this pull request as draft
July 11, 2026 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172. I'm not sure how to test this in mixin tests due to each test being in one file, but I ran my accessor test suite on it, and it worked fine.